Skip to content

The correct Kernel size is 5*5 not 3*3 #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

The correct Kernel size is 5*5 not 3*3 #1485

wants to merge 2 commits into from

Conversation

javadr
Copy link

@javadr javadr commented Apr 24, 2021

There is a subtle issue with PyTorch 60-Minute Blitz in designing depicted model by this figure. As the picture shows it has a kernel of size 5*5 not 3*3. Since this page is a tutorial for beginners, it seems too confusable for them (including me :D) to recognize that there is a typo in the code.

Both conv1 and conv2 in the code must have kernel_size=5 not 3 in compliance with the shown model at the beginning of the article.

Consequently, the output of the code in the page has to be fixed with kernel_size=(5, 5) like below:

Net(
    (conv1): Conv2d(1, 6, kernel_size=(5, 5), stride=(1, 1))
    (conv2): Conv2d(6, 16, kernel_size=(5, 5), stride=(1, 1))
    (fc1): Linear(in_features=400, out_features=120, bias=True)
    (fc2): Linear(in_features=120, out_features=84, bias=True)
    (fc3): Linear(in_features=84, out_features=10, bias=True)
)

P.S.
I had also added an issue last year about this mismatched dimension.

@facebook-github-bot
Copy link
Contributor

Hi @javadr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Apr 24, 2021 •
edited
Loading

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 71dffef

https://deploy-preview-1485--pytorch-tutorials-preview.netlify.app

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@holly1238
Copy link
Contributor

Closing this PR. This issue was fixed and merged in #1257.

@holly1238 holly1238 closed this Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javadr @facebook-github-bot @holly1238